This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fortran/25756 -- fix statement label on empty statements


On Thu, Jan 12, 2006 at 06:14:23PM -0500, Andrew Pinski wrote:
 
>> 2006-01-12  Steven G. Kargl  <kargls@comcast.net>
>> 
>> 	PR fortran/25756
>> 	(Ported from G95)
>> 	* symbol.c (gfc_free_st_label): Give variable meaningful name; Remove
>> 	unneeded parenthesis; Fix-up the head of the list.
>
>This looks good.  I might not reference g95 but it is not a big deal.
>Also the semicolons really should be full stops (periods).

Just as a sidenote, in fixed-form, the locus seems to be off in
next_fixed(). While the first one may be ok as it is pointing to column
<= 5, the second one looks like it is really off by far. E.g.:

 In file warnings_are_errors_1.f:8

0      ! { dg-error "Zero is not a valid statement label" }             
    1
Warning: Zero is not a valid statement label at (1)
 In file warnings_are_errors_1.f:10

1   ! { dg-error "Ignoring statement label in empty statement" }        
                                                                       1
Error: Non-numeric character in statement label at (1)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]