This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Gfortran, patch] Fix simplify char and ichar intrinsic
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Feng Wang <wf_cs at yahoo dot com>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Sat, 7 Jan 2006 11:11:36 -0800
- Subject: Re: [Gfortran, patch] Fix simplify char and ichar intrinsic
- References: <20060106102910.63865.qmail@web15602.mail.cnb.yahoo.com>
On Fri, Jan 06, 2006 at 06:29:10PM +0800, Feng Wang wrote:
>
> > Before applying the patch, we get
> > ichar (char (255)) = -1
> >
> > Fortran ChangeLog entry:
> > 2006-01-06 Feng Wang <fengwang@nudt.edu.cn>
> >
> > * simplify.c (gfc_simplify_char): Use UCHAR_MAX instead of literal
> > constant.
> > (gfc_simplify_ichar): Get the result from unsinged char and in the
> > range 0 to UCHAR_MAX instead of CHAR_MIN to CHAR_MAX.
> > Testsuite ChangeLog entry:
> > 2006-01-06 Feng Wang <fengwang@nudt.edu.cn>
> >
> > * gfortran.dg/intrinsic_i_char.f90: New test.
> >
This is OK. But, please name the testcase ichar_2.f90.
We already have ichar_1.f90.
--
Steve