This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran] PR24268 whitespace in format strings. Revised

Jerry DeLisle wrote:
>>While trivial, this should still be accompanied by a testcase. 
> 
> 
> Do you mean in addition to fmt_white.f that is already committed to trunk?
> (see attached)

Yes, I think you should also test that a similar construct is rejected in
free-form source code, e.g.
{ dg-do compile }
100 FORMAT(2g1 1.3) ! { dg-error }
END
and possibly a few variations.

>>The same patch
>>is also needed in the preceding case, around line 210, probably it would be
>>better to make the number parsing code a static function.
> 
> Hmmm. I will look into this a bit.

Thanks,
- Tobi
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]