This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Patch, fortran] PR24174 real(10) and complex(10) array IO broken.
- From: Janne Blomqvist <jblomqvi at cc dot hut dot fi>
- To: FX Coudert <fxcoudert at gmail dot com>
- Cc: GNU GFortran <fortran at gcc dot gnu dot org>, GCC patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 6 Nov 2005 20:41:39 +0200
- Subject: Re: [Patch, fortran] PR24174 real(10) and complex(10) array IO broken.
- References: <20051011055737.GI3918@vipunen.hut.fi> <20051017210653.GL24358@vipunen.hut.fi> <43549090.2010609@gmail.com> <20051018175625.GM24358@vipunen.hut.fi> <20051025060922.GB28999@vipunen.hut.fi> <435E0DBE.5050409@gmail.com> <20051105163323.GE21942@vipunen.hut.fi> <436D2AF4.7080704@gmail.com>
On Sat, Nov 05, 2005 at 10:58:12PM +0100, FX Coudert wrote:
> Your patch is OK with the following comments:
>
> >! { dg-do run }
> >! { dg-require-effective-target fortran_large_real }
> >! PR 24174 and PR 24305
> >program kind10_formatted_io
> > ! This should be kind=10 on systems that support it
> > integer, parameter :: k = selected_real_kind (precision (0.0_8) + 1)
>
> This comment it not right. On some systems it will be kind=16 (systems
> that do not have a real(kind=10)).
I have committed the patch with the changes in wording proposed by
Brooks Moses (thanks!). I also changed the testcase to test for
(abs(a-b) > 10 * spacing (2.0_k))
instead of testing for exact equality, since we're after all talking
about converting FP numbers to strings and back. For some reason doing
an exact test works for me, but I'm not so sure it will always work.
And, since this is my first ever a) gcc commit and b) svn commit, I
hope I haven't made any major screwups...
--
Janne Blomqvist