This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [PATCH, gfortran] Add BYTE type
- From: FX Coudert <fxcoudert at gmail dot com>
- To: Asher Langton <langton2 at llnl dot gov>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Tue, 09 Aug 2005 18:13:10 +0200
- Subject: Re: [PATCH, gfortran] Add BYTE type
- References: <p06210203bf1db9bf62d3@[128.115.19.2]>
This patch adds a BYTE type to gfortran (enabled by -fbyte-type). This
is just treated as an INTEGER(1), and is for compatibility with old
non-standard Fortran codes. (This type is enabled by default in ifort,
pgf90, and xlf90.)
I have the few following comments (in decreasing order of importance):
* BYTE is supported by g77; so I think we shouldn't add a special
-fbyte-type but include it by default as GFC_STD_GNU or GFC_STD_LEGACY.
* You should add another testcase byte_2.f90, compiled with strict
standard conformance, to check the error messages issued.
* The name for the testcase should be byte_1.f90 (that's the usual
naming convention).
Otherwise, the patch looks fine. Once these comments are addressed (and
other gfortran developpers have had time to give their opinion on the
first point), please submit a revised patch.
Thanks for your help,
FX