This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Patch/gfortran] PR16939, 17192,17193,17202,18689,18890 - forfin al correction.
- From: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>
- To: THOMAS Paul Richard 169137 <prthomas at drfccad dot cea dot fr>
- Cc: "'fortran at gcc dot gnu dot org'" <fortran at gcc dot gnu dot org>,"'paulthomas2 at wanadoo dot fr'" <paulthomas2 at wanadoo dot fr>
- Date: Tue, 31 May 2005 19:48:06 +0200
- Subject: Re: [Patch/gfortran] PR16939, 17192,17193,17202,18689,18890 - forfin al correction.
- References: <756DFD3DE8F1D411A59A00306E06E84702C4274D@drfccad.cad.cea.fr>
THOMAS Paul Richard 169137 wrote:
> --- 1119,1127 ----
> /* Access the previously obtained result. */
> gfc_conv_tmp_array_ref (se);
> gfc_advance_se_ss_chain (se);
> +
> + /* Bundle in the string length. */
> + se->string_length=len;
^^ spaces still missing.
> return;
> }
> }
You have also not used build_int_cst where I suggested it, but I found another
places where it's not used, so I'll have to go over the files anyway. There's
also still a single pair of parentheses around a singleton left :-)
This patch with the requested cleanups, the testcases and the trivial
followups are ok for the mainline and 4.0.
- Thanks