This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix fortran/PR20846 "inquire(FILE=..., UNIT=...) not flagged as error"

From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
To: GCC patches <gcc-patches at gcc dot gnu dot org>, GNU GFortran <fortran at gcc dot gnu dot org>
Date: Sat, 28 May 2005 11:43:51 -0700
Subject: Re: [PATCH] Fix fortran/PR20846 "inquire(FILE=..., UNIT=...) not flagged as error"
References: <20050524180210.GA20504@vipunen.hut.fi>

On Tue, May 24, 2005 at 09:02:11PM +0300, Janne Blomqvist wrote:
> Hello,
> 
> attached patch fixes PR 20846 "inquire(FILE=..., UNIT=...) not flagged
> as error".
> 
> ChangeLog:
> 
> 
>         PR fortran/20846
> 
>         * trans-io.c (gfc_trans_inquire): Add sanity check for UNIT and
>         FILE.
> 
> Patch itself is attached.
> 

Janne's patch modified trans-io.c and I could not get
the error message to print a sane locus incorrect line.
I also recall that Paul (or Tobi) wanted to avoid error
messages coming from the trans-* files if possible.  So,
I've moved Janne's patch into io.c.  See attached patch
and testcase.  Bootstrapped and regression tested on
mainline.  Ok for mainline?  Ok for 4.0 after regtesting.

-- 
Steve

Attachment: io.c.diff
Description: Text document

Attachment: inquire_8.f90
Description: Text document

Follow-Ups:
- Re: [PATCH] Fix fortran/PR20846 "inquire(FILE=..., UNIT=...) not flagged as error"
  - From: Steve Kargl

References:
- [PATCH] Fix fortran/PR20846 "inquire(FILE=..., UNIT=...) not flagged as error"
  - From: Janne Blomqvist

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]