This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Patch,libgfortran & patch,fortran] Namelist
- From: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>
- To: Paul Thomas <paulthomas2 at wanadoo dot fr>
- Cc: fortran at gcc dot gnu dot org, patch <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 15 Apr 2005 18:11:46 +0200
- Subject: Re: [Patch,libgfortran & patch,fortran] Namelist
- References: <425ED46F.2070005@wanadoo.fr>
[ added gcc-patches@ since that is where all patches should go ]
Paul Thomas wrote:
> ! p = write_block (len + 2);
> ! if (!p)
> ! goto query_return;
> ! memcpy (p, "&", 1);
*p = '&';
> ! p = write_block (len + 2);
> ! if (!p)
> ! goto query_return;
> ! memcpy (p, " ", 1);
*p = ' ';
> ! memcpy ((char*)(p + 1), nl->var_name, len);
> ! memcpy ((char*)(p + len + 1), "\n", 1);
We might have to add support for DOS-style line-breaks here, or is this
handled somewhere further down the stream?
> ! /* Flush the stream to force immediate output. */
> !
> ! flush (current_unit->s);
Is this for debugging, or is this a requirement?
I still see a number of formatting errors, but I don't think they're reason
enough to hold up the patch any further. From my POV this is ok.
- Tobi