Re: Reviewers Was: Re: Fortran/PR19303 PATCH: Runtime selection ofrecord markers for unformatted sequential io

[Toon Moene <toon at moene dot indiv dot nluug dot nl>]

Gerald Pfeifer wrote:

> On Thu, 24 Feb 2005, Toon Moene wrote:
>
> > Here's what I came up with (attached).
>
> Wearing my wwwdocs hat, I've got some comments, but not many. ;-)
>
> Some of the lines are a bit long, it would be good to avoid lines longer
> than, say 75 or so, characters.

All of them are at least under 80 now, most under 75.

> --- index.html	Thu Feb 24 19:51:06 2005
> + <li>All normal requirements for patch submission (testing, changelog entries, 
> + etc) still apply, and reviewers should ensure that these have been met before 
> + approving changes.</li>
>
> I believe a link from "normal requirements" to contribute.html would be a
> good idea.

Done.

> + <li>Approval should be necessary for patches which don't fall under the
> + obvious rule, so with this list put in place everybody (except maintainers)
> + should <b>still</b> seek approval for his/her patches.</li>
>
> <em>still</em> or <strong>still</strong>

Implemented the latter.

> + <li>Patches should only be reviewed by people who know the affected parts of
> + the compiler.  I.e. the reviewer has to be sure he/she knows stuff well enough to
> + make a good judgement.</li>
>
> Listing this a special requirement here might be considered as an 
> indication that this is generally not required?
>
> + <li>We are all reasonable people, and nobody is working under employer pressure
> + or needs an ego-boost badly, so in general we assume that noone
> + deliberately does anything stupid :-)</li>
>
> Hmm, do we really need that?  There is some fun factor attached to that,
> but I generally try to avoid this kind of statements and also try to
> keep docs as short as possible.

I kept the last two paragraphs you've questioned.  I foresee they will 
be removed (or completely rephrased) in the future, but at present they 
reflect how we feel about the gfortran review process.

Thanks for your feedback.

I committed the following (attached).

Cheers,

--
Toon Moene - e-mail: toon@moene.indiv.nluug.nl - phone: +31 346 214290
Saturnushof 14, 3738 XG  Maartensdijk, The Netherlands
Maintainer, GNU Fortran 77: http://gcc.gnu.org/onlinedocs/g77_news.html
A maintainer of GNU Fortran 95: http://gcc.gnu.org/fortran/

*** index.html.orig	Sat Sep 11 13:32:11 2004
--- index.html	Fri Feb 25 19:56:48 2005
*************** We provide read access to our developmen
*** 55,60 ****
--- 55,96 ----
  <a href="../cvs.html">anonymous CVS</a>. If you do not have CVS access (for
  instance because you are behind a firewall prohibiting the CVS protocol),
  you might want to download <a href="../snapshots.html">snapshots</a>.</p>
+ <p>Contributions will be reviewed by the following people:</p>
+ <ul>
+ <li>Paul Brook</li>
+ <li>Steven Bosscher</li>
+ <li>Toon Moene</li>
+ <li>Tobias Schlueter</li>
+ <li>Bud Davis</li>
+ <li>Janne Blomqvist</li>
+ <li>Steve Kargl</li>
+ </ul>
+ <p>under the rules specified below:</p>
+ <ul>
+ <li>Paul Brook and Steven Bosscher can unilaterally commit patches they
+ deem reasonable, as they have set up the gfortran tree in GCC.</li>
+ <li>All <a href="../contribute.html">normal requirements</a> for patch
+ submission (assignment of copyright to the FSF, testing, changelog entries,
+ etc) still apply, and reviewers should ensure that these have been met
+ before approving changes.</li>
+ <li>Approval should be necessary for patches which don't fall under the
+ obvious rule, so with this list put in place everybody (except maintainers)
+ should <strong>still</strong> seek approval for his/her patches.</li>
+ <li>Patches should only be reviewed by people who know the affected parts
+ of the compiler.  I.e. the reviewer has to be sure he/she knows stuff well
+ enough to make a good judgement.</li>
+ <li>Large/complicated patches should still go by one of our maintainers.</li>
+ <li>We are all reasonable people, and nobody is working under employer
+ pressure or needs an ego-boost badly, so in general we assume that noone
+ deliberately does anything stupid :-)</li>
+ </ul>
+ <p>The directories involved are:</p>
+ <ol>
+ <li>gcc/gcc/fortran/</li>
+ <li>gcc/gcc/testsuite/gfortran.dg/</li>
+ <li>gcc/gcc/testsuite/gfortran.fortran-torture/</li>
+ <li>gcc/libgfortran/</li>
+ </ol>
  
  <h2>Binaries</h2>
  <p>The GNU project is about providing source code for its programs.