Re: Reviewers Was: Re: Fortran/PR19303 PATCH: Runtime selection ofrecord markers for unformatted sequential io

[Toon Moene <toon at moene dot indiv dot nluug dot nl>]

I wrote, concerning the reviewers list for (lib)gfortran patches:

> I'll think up something for the http://gcc.gnu.org/fortran home page 
> tomorrow (am too sleepy now).

Here's what I came up with (attached).

Is this OK ?

--
Toon Moene - e-mail: toon@moene.indiv.nluug.nl - phone: +31 346 214290
Saturnushof 14, 3738 XG  Maartensdijk, The Netherlands
Maintainer, GNU Fortran 77: http://gcc.gnu.org/onlinedocs/g77_news.html
A maintainer of GNU Fortran 95: http://gcc.gnu.org/fortran/

*** index.html.orig	Sat Sep 11 13:32:11 2004
--- index.html	Thu Feb 24 19:51:06 2005
*************** We provide read access to our developmen
*** 55,60 ****
--- 55,95 ----
  <a href="../cvs.html">anonymous CVS</a>. If you do not have CVS access (for
  instance because you are behind a firewall prohibiting the CVS protocol),
  you might want to download <a href="../snapshots.html">snapshots</a>.</p>
+ <p>Contributions will be reviewed by the following people:</p>
+ <ul>
+ <li>Paul Brook</li>
+ <li>Steven Bosscher</li>
+ <li>Toon Moene</li>
+ <li>Tobias Schlueter</li>
+ <li>Bud Davis</li>
+ <li>Janne Blomqvist</li>
+ <li>Steve Kargl</li>
+ </ul>
+ <p>under the rules specified below:</p>
+ <ul>
+ <li>Paul Brook and Steven Bosscher can unilaterally commit patches they deem
+ reasonable, as they have set up the gfortran tree in GCC.</li>
+ <li>All normal requirements for patch submission (testing, changelog entries, 
+ etc) still apply, and reviewers should ensure that these have been met before 
+ approving changes.</li>
+ <li>Approval should be necessary for patches which don't fall under the
+ obvious rule, so with this list put in place everybody (except maintainers)
+ should <b>still</b> seek approval for his/her patches.</li>
+ <li>Patches should only be reviewed by people who know the affected parts of
+ the compiler.  I.e. the reviewer has to be sure he/she knows stuff well enough to
+ make a good judgement.</li>
+ <li>Large / complicated patches should still go by one of our maintainers.</li>
+ <li>We are all reasonable people, and nobody is working under employer pressure
+ or needs an ego-boost badly, so in general we assume that noone
+ deliberately does anything stupid :-)</li>
+ </ul>
+ <p>The directories involved are:</p>
+ <ol>
+ <li>gcc/gcc/fortran/</li>
+ <li>gcc/gcc/testsuite/gfortran.dg/</li>
+ <li>gcc/gcc/testsuite/gfortran.fortran-torture/</li>
+ <li>gcc/libgfortran/</li>
+ </ol>
  
  <h2>Binaries</h2>
  <p>The GNU project is about providing source code for its programs.