This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [gfortran] Fix PR 17776: Add SYSTEM intrinsics
- From: Paul Brook <paul at codesourcery dot com>
- To: fortran at gcc dot gnu dot org
- Cc: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>,patch <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 4 Oct 2004 19:08:55 +0100
- Subject: Re: [gfortran] Fix PR 17776: Add SYSTEM intrinsics
- Organization: CodeSourcery
- References: <415F0EAB.2020605@physik.uni-muenchen.de>
> Built, tested and verified. Do we need a testcase? OK?
I suspect it's not possible to write a portable testcase.
> 2004-10-02 Tobias Schlueter <tobias.schlueter@physik.uni-muenchen.de>
>
> PR fortran/17776
> fortran/
> * check.c (gfc_check_system_sub): New function.
> * gfortran.h (gfc_generic_isym_id): Add GFC_ISYM_SYSTEM.
> * intrinsic.c (add_functions): Add 'system'.
> (add_subroutines): Add 'system'.
> * intrinsic.h (gfc_check_etime_sub, gfc_check_getcwd_sub):
> Move prototypes to other suborutines.
> (gfc_check_system_sub, gfc_resolve_system, gfc_resolve_system_sub):
> Add prototype.
> (gfc_resolve_system_clock): Fix formatting of prototype.
> * iresolve.c (gfc_resolve_system, gfc_resolve_system_sub): New
> functions.
> * trans-intrinsic.c (gfc_conv_intrinsic_function): Deal with
> GFC_ISYM_SYSTEM.
> libgfortran/
> * intrinsics/system.c: New file.
> * Makefile.am: Add new file.
Presumably you'll also regenerate Makefile.in.
> +try
> +gfc_check_system_sub (gfc_expr * cmd, gfc_expr * status)
> +{
> + ?if (kind_value_check (status, 1, gfc_default_integer_kind) == FAILURE)
> + ? ?return FAILURE;
This should be 4, not gfc_default_integer_kind.
Ok with that change.
Paul