This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [gfortran] PR 15481: Separate common symbols
- From: Paul Brook <paul at codesourcery dot com>
- To: fortran at gcc dot gnu dot org
- Cc: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>,patch <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 28 Jun 2004 01:30:07 +0100
- Subject: Re: [gfortran] PR 15481: Separate common symbols
- Organization: CodeSourcery
- References: <40DD99B3.1010102@physik.uni-muenchen.de>
> While I was touching module.c, I added an obvious fix to mio_gmp_real,
> where we would misprint negative numbers.
I'd prefer it if this were applied as a separate change.
> This introduces a regression in that the error
> gfc_error ("DATA statement at %C may not initialize variable "
> "'%s' from blank COMMON", sym->name);
> will not be emitted any longer. I will fix that in a followup, once I
> figure out a place to do this now.
>
> Looking over the patch, I see that I didn't install logic to dump common
> blocks. I will fix this once this patch is in.
>
> - Tobi
>
> 2004-06-26 Tobias Schlueter <tobias.schlueter@physik.uni-muenchen.de>
<snip>
The changes described in the changelog are ok.
However the patch includes chunks from at least two other patches. The
gfc_match_end chunk shouldn't be there at all, and the global symbol stuff
you already submitted by itself.
Paul