Bug 32859 - [4.3 Regression] "make info" fails in libiberty
Summary: [4.3 Regression] "make info" fails in libiberty
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: other (show other bugs)
Version: 4.3.0
: P3 normal
Target Milestone: 4.3.0
Assignee: Not yet assigned to anyone
URL:
Keywords: documentation
Depends on:
Blocks:
 
Reported: 2007-07-23 06:04 UTC by Thomas Koenig
Modified: 2007-07-24 00:32 UTC (History)
3 users (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Koenig 2007-07-23 06:04:41 UTC
"make info" currently fails on trunk:

Doing info in i686-pc-linux-gnu/libiberty
make[2]: Entering directory `/home/ig25/gcc-bin/trunk/i686-pc-linux-gnu/libiberty'
perl ../../../../gcc/trunk/libiberty/gather-docs ../../../../gcc/trunk/libiberty ../../../../gcc/trunk/libiberty/functions.texi alloca.c argv.c asprintf.c atexit.c basename.c bcmp.c bcopy.c bsearch.c bzero.c calloc.c choose-temp.c clock.c concat.c cp-demangle.c cp-demint.c cplus-dem.c dyn-string.c fdmatch.c ffs.c fibheap.c filename_cmp.c floatformat.c fnmatch.c fopen_unlocked.c getcwd.c getopt.c getopt1.c getpagesize.c getpwd.c getruntime.c gettimeofday.c hashtab.c hex.c index.c insque.c lbasename.c lrealpath.c make-relative-prefix.c make-temp-file.c md5.c memchr.c memcmp.c memcpy.c memmove.c mempcpy.c memset.c mkstemps.c objalloc.c obstack.c partition.c pexecute.c pex-common.c pex-djgpp.c pex-msdos.c pex-one.c pex-unix.c pex-win32.c physmem.c putenv.c random.c regex.c rename.c rindex.c safe-ctype.c setenv.c sigsetmask.c snprintf.c sort.c spaces.c splay-tree.c stpcpy.c stpncpy.c strcasecmp.c strchr.c strdup.c strerror.c strncasecmp.c strncmp.c strrchr.c strsignal.c strstr.c strtod.c strtol.c strtoul.c strndup.c      strverscmp.c ternary.c tmpnam.c unlink-if-ordinary.c vasprintf.c vfork.c vfprintf.c vprintf.c vsnprintf.c vsprintf.c waitpid.c xatexit.c xexit.c xmalloc.c xmemdup.c xstrdup.c xstrerror.c xstrndup.c fnmatch.txh pexecute.txh
echo stamp > stamp-functions
makeinfo --split-size=5000000 --split-size=5000000 -I../../../../gcc/trunk/libiberty ../../../../gcc/trunk/libiberty/libiberty.texi
../../../../gcc/trunk/libiberty//functions.texi:1477: Unmatched }.
makeinfo: Removing output file `/home/ig25/gcc-bin/trunk/i686-pc-linux-gnu/libiberty/libiberty.info' due to errors; use --force to preserve.
make[2]: *** [libiberty.info] Error 1
make[2]: Leaving directory `/home/ig25/gcc-bin/trunk/i686-pc-linux-gnu/libiberty'
make[1]: *** [info-target-libiberty] Error 1
make[1]: Leaving directory `/home/ig25/gcc-bin/trunk'
make: *** [do-info] Error 2

gcc was configured with

../../gcc/trunk/configure --enable-languages=c,fortran --prefix=$HOME --enable-maintainer-mode --disable-multilib

(Shouldn't there be a libiberty component?)

This is a bit of a nuisance because I can't test other
documentation patches.

I have a dded dj to the CC because he was last to touch that
directory.

I've added dj to the CC list because he was the last one to touch that directory.

After the "make info", I get

$ svn diff
Index: functions.texi
===================================================================
--- functions.texi      (revision 126829)
+++ functions.texi      (working copy)
@@ -214,7 +214,7 @@ symbolic name or message.
 
 @end deftypefn
 
-@c argv.c:293
+@c argv.c:348
 @deftypefn Extension void expandargv (int *@var{argcp}, char ***@var{argvp})
 
 The @var{argcp} and @code{argvp} arguments are pointers to the usual
@@ -268,15 +268,16 @@ value 1).  If @var{valu} is zero, zero i
 
 @end deftypefn
 
-@c filename_cmp.c:28
+@c filename_cmp.c:32
 @deftypefn Extension int filename_cmp (const char *@var{s1}, const char *@var{s2})
 
-Return zero if the two paths @var{s1} and @var{s2} are equivalent.
-If not equivalent, the returned value is similar to what strcmp would
-return.  In other words, it returns a negative value if @var{s1} is less
-than @var{s2}, or a positive value if @var{s2} is greater than @var{s2}.
+Return zero if the two file names @var{s1} and @var{s2} are equivalent.
+If not equivalent, the returned value is similar to what @code{strcmp}
+would return.  In other words, it returns a negative value if @var{s1}
+is less than @var{s2}, or a positive value if @var{s2} is greater than
+@var{s2}.
 
-This function does not normalize path names. As a result, this function
+This function does not normalize file names.  As a result, this function
 will treat filenames that are spelled differently as different even in
 the case when the two filenames point to the same underlying file.
 However, it does handle the fact that on DOS-like file systems, forward
@@ -1471,6 +1472,15 @@ does the return value.  The third argume
 
 @end deftypefn
 
+@c argv.c:293
+@deftypefn Extension int writeargv (const char **@var{argv}, FILE *@{file})
+
+Write each member of ARGV, handling all necessary quoting, to the file
+named by FILE, separated by whitespace.  Return 0 on success, non-zero
+if an error occurred while writing to FILE.
+
+@end deftypefn
+
 @c xatexit.c:11
 @deftypefun int xatexit (void (*@var{fn}) (void))
Comment 1 Thomas Koenig 2007-07-23 06:05:26 UTC
Setting to "blocker" as I can't do "make info" checks at the moment.
Comment 2 Thomas Koenig 2007-07-23 17:17:09 UTC
I currently cannot check the documentation changes requried
in the review for PR 30814.  The condition of a Blocker,
"Blocks development and/or testing work" is fulfilled, IMHO.

Andrew, you marked this as a non-blocker.  How else can I
check documentatin patches?
Comment 3 DJ Delorie 2007-07-23 17:29:34 UTC
Subject: Re:   New: [4.3 Regression] "make info" fails in libiberty


I've checked in a fix for this.
Comment 4 Thomas Koenig 2007-07-23 19:47:15 UTC
Yes, it's fixed now.

Thanks!