Bug 32645 - Possibly wrong assertions in GTK Peer
Summary: Possibly wrong assertions in GTK Peer
Status: RESOLVED FIXED
Alias: None
Product: classpath
Classification: Unclassified
Component: awt (show other bugs)
Version: unspecified
: P3 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-06 12:12 UTC by Peter Molnar
Modified: 2012-10-26 07:36 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2007-07-06 12:29:14


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Molnar 2007-07-06 12:12:10 UTC
In Java_gnu_java_awt_peer_gtk_ComponentGraphicsCopy_copyPixbuf (native/jni/gtk-peer/gnu_java_awt_peer_gtk_ComponentGraphicsCopy.c, CVS head) there are possibly two wrong assertions that fail on my system:

Line 105:

  GtkWidget *widget = NULL;
  void *ptr = NULL;

  gdk_threads_enter();

  ptr = gtkpeer_get_widget (env, peer);
  g_assert (widget != NULL); // <------------ FAILS

  widget = GTK_WIDGET (ptr);
  g_assert (ptr != NULL);

It seems to me like the assertions should be swapped.
Comment 1 Roman Kennke 2007-07-06 12:29:14 UTC
Yeah right, these need to be swapped.
Comment 2 cvs-commit@developer.classpath.org 2007-07-10 14:34:19 UTC
Subject: Bug 32645

CVSROOT:	/cvsroot/classpath
Module name:	classpath
Changes by:	Roman Kennke <rabbit78>	07/07/10 14:33:57

Modified files:
	native/jni/gtk-peer: 
	                     gnu_java_awt_peer_gtk_ComponentGraphicsCopy.c 

Log message:
	2007-07-10  Roman Kennke  <roman@kennke.org>
	
		PR 32645
		* native/jni/gtk-peer/gnu_java_awt_peer_gtk_ComponentGraphicsCopy.c
		(copyPixbuf): Swap asserts.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/classpath/native/jni/gtk-peer/gnu_java_awt_peer_gtk_ComponentGraphicsCopy.c?cvsroot=classpath&r1=1.5&r2=1.6



Comment 3 Andrew John Hughes 2007-12-25 01:42:45 UTC
Should this still be open?
Comment 4 Andrew John Hughes 2012-10-26 07:36:41 UTC
Appears to have been fixed.