Bug 31329 - Build error because of -Werror defaulting to enabled
Summary: Build error because of -Werror defaulting to enabled
Status: RESOLVED FIXED
Alias: None
Product: classpath
Classification: Unclassified
Component: classpath (show other bugs)
Version: 0.93
: P3 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-23 20:06 UTC by Marc St-Jean
Modified: 2008-01-26 10:34 UTC (History)
3 users (show)

See Also:
Host: x86 RHEL 3.6
Target: MIPS linux 2.6.18
Build:
Known to work:
Known to fail:
Last reconfirmed: 2007-03-28 17:47:29


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marc St-Jean 2007-03-23 20:06:46 UTC
Using --disable-Werror solved the problem but several hours were wasted identifying this. Since the default is enabled these errors should be fixed so it builds out-of-the-box.

These generate unused parm warnings which break the build. The first is due to the target platform not having libiconv, the second I'm not sure of the reason.

native/jni/java-nio/gnu_java_nio_charset_iconv_IconvDecoder
native/jni/java-net/java_net_VMNetworkInterface
Comment 1 Tom Tromey 2007-03-28 17:47:29 UTC
Could you post the full errors here?
That would help, thanks.
Comment 2 Andrew John Hughes 2007-12-25 01:42:02 UTC
Still no answer on what these errors are.  FWIW, I always build with --enable-Werror (so wasn't aware it was the default, and I don't think that's always been the case) and I've not experienced any problems recently on GNU/Liux with either x86_64 or ppc64 archs as I recall.

I'll change this to waiting for now in the hope that we get a list of errors.
Comment 3 Richard Sandiford 2008-01-25 10:03:14 UTC
I think we can safely close this as fixed.  I build cross
mips64-linux-gnu builds with --enable-werror and haven't
seen any such problems.  This PR was opened many months ago,
and classpath has changed a lot since then, so it's not
surprising if the problem is no longer there.
Comment 4 Dalibor Topic 2008-01-25 12:23:15 UTC
I agree. GNU Classpath build logs on debian show no problems for mips builds with 0.96.1, so whatever it was it seems fixed. While I can see some warnings for mid/sound native code at http://buildd.debian.org/fetch.cgi?pkg=classpath;ver=2%3A0.96.1-1;arch=mips;stamp=1198888704 they don't seem to cause the code to fail to build.
Comment 5 Richard Sandiford 2008-01-26 10:34:28 UTC
"robilad at kaffe dot org" <gcc-bugzilla@gcc.gnu.org> writes:
> ------- Comment #4 from robilad at kaffe dot org  2008-01-25 12:23 -------
> I agree. GNU Classpath build logs on debian show no problems for mips builds
> with 0.96.1, so whatever it was it seems fixed. While I can see some warnings
> for mid/sound native code at
> http://buildd.debian.org/fetch.cgi?pkg=classpath;ver=2%3A0.96.1-1;arch=mips;stamp=1198888704
> they don't seem to cause the code to fail to build.

OK, thanks.