Bug 29288 - [4.1 only] All intrinsics are allowed as actual arguments
Summary: [4.1 only] All intrinsics are allowed as actual arguments
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: fortran (show other bugs)
Version: 4.2.0
: P3 normal
Target Milestone: 4.2.0
Assignee: Francois-Xavier Coudert
URL: http://gcc.gnu.org/ml/fortran/2006-10...
Keywords: accepts-invalid, diagnostic, patch
Depends on:
Blocks: 16580
  Show dependency treegraph
 
Reported: 2006-09-29 16:41 UTC by Francois-Xavier Coudert
Modified: 2006-10-18 20:59 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Known to work: 4.2.0
Known to fail: 4.1.2
Last reconfirmed: 2006-09-29 16:41:26


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Francois-Xavier Coudert 2006-09-29 16:41:06 UTC
(vaguely related to PR16580)

We're currently not checking if an intrinsic is allowed to be used as an actual argument or not (and it's a regression wrt g77):

$ ifort a.f
fortcom: Error: a.f, line 2: This intrinsic procedure cannot be passed as an actual argument.   [ICHAR]
      call BAR(ichar)
---------------^
compilation aborted for a.f (code 1)
$ pgf90 a.f
PGF90-S-0073-Intrinsic or predeclared, ichar, cannot be passed as an argument (a.f: 2)
  0 inform,   0 warnings,   1 severes, 0 fatal for MAIN
$ gfortran a.f
/tmp/cckKTcIB.o(.text+0x5): In function `MAIN__':
: undefined reference to `specific__ichar_1'
/tmp/cckKTcIB.o(.text+0xa): In function `MAIN__':
: undefined reference to `bar_'
collect2: ld returned 1 exit status
Comment 1 Francois-Xavier Coudert 2006-10-02 07:11:21 UTC
Patch submitted here: http://gcc.gnu.org/ml/fortran/2006-10/msg00022.html
Comment 2 Francois-Xavier Coudert 2006-10-07 13:34:27 UTC
Subject: Bug 29288

Author: fxcoudert
Date: Sat Oct  7 13:34:16 2006
New Revision: 117534

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=117534
Log:
	PR fortran/16580
	PR fortran/29288

	* gcc/fortran/intrinsic.c (add_sym): Define the actual_ok when a
	gfc_intrinsic_sym structure is filled.
	(gfc_intrinsic_actual_ok): New function.
	(add_sym_0s, add_sym_1s, add_sym_2s, add_sym_3s, add_sym_4s,
	add_sym_5s): Intrinsic subroutines are not allowed as actual
	arguments, so we remove argument actual_ok.
	(add_functions): Correct the values for actual_ok of all intrinsics.
	(add_subroutines): Remove the actual_ok argument, which was never used.
	* gcc/fortran/intrinsic.h (gfc_intrinsic_actual_ok): New prototype.
	* gcc/fortran/gfortran.h (gfc_resolve_index_func): New prototype.
	* gcc/fortran/resolve.c (resolve_actual_arglist): Check whether
	an intrinsic used as an argument list is allowed there.
	* gcc/fortran/iresolve.c (gfc_resolve_index_func): New function.
	(gfc_resolve_len): Change intrinsic function name to agree with
	libgfortran.
	* gcc/fortran/trans-decl.c (gfc_get_extern_function_decl): Add
	new case, because some specific intrinsics take 3 arguments.
	* gcc/fortran/intrinsic.texi: DIMAG is a GNU extension.

	* libgfortran/Makefile.am: Add the new files to the build
	process, and rules to build them.
	* libgfortran/Makefile.in: Regenerate.
	* libgfortran/m4/misc_specifics.m4: New file.
	* libgfortran/m4/specific.m4: Add new special cases for function
	with complex argument and real result, like abs_c* and aimag_c*.
	* libgfortran/intrinsics/f2c_specifics.F90: Add specifics for
	AIMAG, ASINH, ACOSH and ATANH.
	* libgfortran/generated/_aimag_c4.F90: New file.
	* libgfortran/generated/_aimag_c8.F90: New file.
	* libgfortran/generated/_asinh_r10.F90: New file.
	* libgfortran/generated/_acosh_r16.F90: New file.
	* libgfortran/generated/_aimag_c10.F90: New file.
	* libgfortran/generated/_atanh_r16.F90: New file.
	* libgfortran/generated/_acosh_r4.F90: New file.
	* libgfortran/generated/_acosh_r8.F90: New file.
	* libgfortran/generated/_asinh_r4.F90: New file.
	* libgfortran/generated/_asinh_r8.F90: New file.
	* libgfortran/generated/_asinh_r16.F90: New file.
	* libgfortran/generated/_atanh_r4.F90: New file.
	* libgfortran/generated/_atanh_r8.F90: New file.
	* libgfortran/generated/_acosh_r10.F90: New file.
	* libgfortran/generated/misc_specifics.F90: New file.
	* libgfortran/generated/_aimag_c16.F90: New file.
	* libgfortran/generated/_atanh_r10.F90: New file.

	* gcc/testsuite/gfortran.fortran-torture/execute/specifics.f90:
	Add tests for using all possible intrinsics as actual arguments.
	* gcc/testsuite/gfortran.dg/specifics_1.f90: Add tests for using
	all possible intrinsics as actual arguments.
	* gcc/testsuite/gfortran.dg/specifics_2.f90: New file.
	* gcc/testsuite/gfortran.dg/specifics_3.f90: New file.

Added:
    trunk/gcc/testsuite/gfortran.dg/specifics_2.f90
    trunk/gcc/testsuite/gfortran.dg/specifics_3.f90
    trunk/libgfortran/generated/_acosh_r10.F90
    trunk/libgfortran/generated/_acosh_r16.F90
    trunk/libgfortran/generated/_acosh_r4.F90
    trunk/libgfortran/generated/_acosh_r8.F90
    trunk/libgfortran/generated/_aimag_c10.F90
    trunk/libgfortran/generated/_aimag_c16.F90
    trunk/libgfortran/generated/_aimag_c4.F90
    trunk/libgfortran/generated/_aimag_c8.F90
    trunk/libgfortran/generated/_asinh_r10.F90
    trunk/libgfortran/generated/_asinh_r16.F90
    trunk/libgfortran/generated/_asinh_r4.F90
    trunk/libgfortran/generated/_asinh_r8.F90
    trunk/libgfortran/generated/_atanh_r10.F90
    trunk/libgfortran/generated/_atanh_r16.F90
    trunk/libgfortran/generated/_atanh_r4.F90
    trunk/libgfortran/generated/_atanh_r8.F90
    trunk/libgfortran/generated/misc_specifics.F90
    trunk/libgfortran/m4/misc_specifics.m4
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/intrinsic.c
    trunk/gcc/fortran/intrinsic.h
    trunk/gcc/fortran/intrinsic.texi
    trunk/gcc/fortran/iresolve.c
    trunk/gcc/fortran/resolve.c
    trunk/gcc/fortran/trans-decl.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/specifics_1.f90
    trunk/gcc/testsuite/gfortran.fortran-torture/execute/specifics.f90
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/Makefile.am
    trunk/libgfortran/Makefile.in
    trunk/libgfortran/intrinsics/f2c_specifics.F90
    trunk/libgfortran/m4/specific.m4

Comment 3 Francois-Xavier Coudert 2006-10-18 20:59:26 UTC
Fixed on 4.2, won't backport to 4.1.