Bug 23238 - split-for-gcj.sh should use CONFIG_SHELL
: split-for-gcj.sh should use CONFIG_SHELL
Status: RESOLVED FIXED
Product: classpath
Classification: Unclassified
Component: classpath
: 0.17
: P2 critical
: 0.18
Assigned To: Not yet assigned to anyone
:
: build
:
:
  Show dependency treegraph
 
Reported: 2005-08-04 21:12 UTC by Eric Botcazou
Modified: 2005-09-06 12:42 UTC (History)
4 users (show)

See Also:
Host:
Target:
Build: *-*-solaris2.*
Known to work:
Known to fail:
Last reconfirmed: 2005-08-04 21:38:06


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Botcazou 2005-08-04 21:12:44 UTC
Libgcj cannot be built on Solaris anymore because /bin/sh is hardcoded in the
script and the code appears to run into several of the numerous limitations/bugs
of the shell.

We recommend setting CONFIG_SHELL=/bin/ksh in order to bootstrap GCC on Solaris
and libgcj should again abide by this setting.
Comment 1 Andrew Pinski 2005-08-04 21:38:06 UTC
Oh, this is truely part of classpath.
Comment 2 Andrew Pinski 2005-08-04 21:38:54 UTC
CC tromey.
Comment 3 Andrew Pinski 2005-08-04 21:41:09 UTC
I think the easy fix would change Makefile.am.
The following line:
JAVAC = $(srcdir)/split-for-gcj.sh && $(MAKE) -f $(srcdir)/Makefile.gcj \
    GCJ='$(GCJ)' compile_classpath='$(top_builddir):$(compile_classpath)'

can be changed to:
JAVAC = $(CONFIG_SHELL) $(srcdir)/split-for-gcj.sh && $(MAKE) -f $(srcdir)/Makefile.gcj \
    GCJ='$(GCJ)' compile_classpath='$(top_builddir):$(compile_classpath)'

That should make it work.
Comment 4 Andreas Tobler 2005-08-08 19:24:49 UTC
With Andrew's suggestion I was able to build and test libjava on
sparc-solaris10.
The results of the testsuite do not look that good. A lot of
java.lang.ClassNotFoundException where raised. But this is definitely another
issue :)
Comment 5 cvs-commit@developer.classpath.org 2005-08-10 20:27:36 UTC
Subject: Bug 23238

CVSROOT:	/cvsroot/classpath
Module name:	classpath
Branch: 	
Changes by:	Tom Tromey <tromey@savannah.gnu.org>	05/08/10 18:40:13

Modified files:
	.              : ChangeLog 
	lib            : Makefile.am 

Log message:
	* lib/Makefile.am (JAVAC): Use $(SHELL) to invoke
	split-for-gcj.sh.  For PR classpath/23238.

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.4376&tr2=1.4377&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/lib/Makefile.am.diff?tr1=1.95&tr2=1.96&r1=text&r2=text




Comment 6 cvs-commit@developer.classpath.org 2005-08-11 17:11:18 UTC
Subject: Bug 23238

CVSROOT:	/cvsroot/classpath
Module name:	classpath
Branch: 	
Changes by:	Tom Tromey <tromey@savannah.gnu.org>	05/08/11 16:40:53

Modified files:
	.              : ChangeLog configure.ac 
	lib            : gen-classlist.sh.in 

Log message:
	For PR classpath/23238:
	* lib/gen-classlist.sh.in: Use @SHELL@; invoke split-for-gcj.sh
	with it.
	* configure.ac (SH): Removed subst.

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.4384&tr2=1.4385&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/configure.ac.diff?tr1=1.97&tr2=1.98&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/lib/gen-classlist.sh.in.diff?tr1=1.28&tr2=1.29&r1=text&r2=text




Comment 7 Andrew Pinski 2005-08-22 12:49:02 UTC
Fixed, classpath should be merged soon too.