Bug 21010 - New gcc.dg/vect tests fail
Summary: New gcc.dg/vect tests fail
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: testsuite (show other bugs)
Version: 4.1.0
: P2 normal
Target Milestone: 4.1.0
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-13 22:01 UTC by Joseph S. Myers
Modified: 2005-04-20 02:06 UTC (History)
3 users (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2005-04-14 00:36:40


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph S. Myers 2005-04-13 22:01:06 UTC
The failures

FAIL: gcc.dg/vect/vect-ifcvt-2.c scan-tree-dump-times vectorized 1 loops 1
FAIL: gcc.dg/vect/vect-ifcvt-3.c scan-tree-dump-times vectorized 1 loops 1
FAIL: gcc.dg/vect/vect-ifcvt-4.c scan-tree-dump-times vectorized 1 loops 1
FAIL: gcc.dg/vect/vect-ifcvt-5.c scan-tree-dump-times vectorized 1 loops 1
FAIL: gcc.dg/vect/vect-ifcvt-6.c scan-tree-dump-times vectorized 1 loops 1
FAIL: gcc.dg/vect/vect-ifcvt-7.c scan-tree-dump-times vectorized 1 loops 1
FAIL: gcc.dg/vect/vect-ifcvt-9.c scan-tree-dump-times vectorized 1 loops 2
FAIL: gcc.dg/vect/vect-none.c scan-tree-dump-times vectorized 0 loops 2
FAIL: gcc.dg/vect/vect-none.c scan-tree-dump-times vectorized 1 loops 1

(all new tests) appeared on mainline between 20050411 and 20050412, on
i686-pc-linux-gnu and ia64-hp-hpux11.23.  Perhaps these tests, added by

2004-04-11  Devang Patel  <dpatel@apple.com>

        * lib/target-supports.exp (check_effective_target_vect_condition): New.
        * gcc.dg/vect/vect-ifcvt-1.c: New test.
        * gcc.dg/vect/vect-ifcvt-2.c: New test.
        * gcc.dg/vect/vect-ifcvt-3.c: New test.
        * gcc.dg/vect/vect-ifcvt-4.c: New test.
        * gcc.dg/vect/vect-ifcvt-5.c: New test.
        * gcc.dg/vect/vect-ifcvt-6.c: New test.
        * gcc.dg/vect/vect-ifcvt-7.c: New test.
        * gcc.dg/vect/vect-none.c: Now one loop is vectorized.

are insufficiently portable.
Comment 1 Devang Patel 2005-04-13 22:47:15 UTC
Subject: Re:  New: New gcc.dg/vect tests fail

But all of them require
     /* { dg-require-effective-target vect_condition } */
So, why they fail on other platforms ?
-
Devang

Comment 2 jsm-csl@polyomino.org.uk 2005-04-14 00:32:33 UTC
Subject: Re:  New gcc.dg/vect tests fail

On Wed, 13 Apr 2005, dpatel at apple dot com wrote:

> But all of them require
>      /* { dg-require-effective-target vect_condition } */
> So, why they fail on other platforms ?

1. They have that text before the dg-do line, which in accordance with the 
documentation in sourcebuild.texi is ineffective.

2. vect-none.c doesn't have that annotation at all (and it still fails).

Comment 3 Andrew Pinski 2005-04-14 00:36:37 UTC
Janis said she would take care of them: 
[17:22] < rth> janis: ping
[17:22] < janis> rth: pong
[17:23] < rth> janis: why is gcc.dg/vect/vect-ifcvt-2.c being tested on i386 even though 
vect_condition is only true for ppc?
[17:23] < janis> rth: no idea, I'll take a look
[17:24] < rth> janis: i assume devang did something wrong, but i can't see what.
[17:30] < janis> rth: you mean the test on the autovect branch? it's run for all targets, the options are 
overridden for powerpc, and the scan-tree-dump-times check is expected to fail on x86 and on 
x86_64
[17:36] < rth> janis: on, i mean on mainline.
[17:36] < janis> I didn't see that test on mainline, is it new today?
[17:37] < rth> janis: within the last day or three.
[17:40] < janis> rth: dg-do needs to come before directives that are local to the gcc testsuite
[17:41] < janis> rth: I'll fix those
[17:41] < rth> janis: thanks.
[17:41] < janis> np

Comment 4 Devang Patel 2005-04-14 00:44:04 UTC
Subject: Re:  New gcc.dg/vect tests fail

Thanks everyone!

Comment 5 Janis Johnson 2005-04-14 01:19:53 UTC
There are additional problems with these tests and I don't have
time to finish looking at them today, but here's some info.
                                                                                
Autovectorization tests should never use 'dg-do run'.  There are
checks in vect.exp that determine whether dg-do-what is 'run' or
'compile' as the default based on whether the test hardware
supports vector instructions.  Rather than switching 'dg-do run'
and 'dg-require-*' I removed the 'dg-do run'.
                                                                                
Tests that generate temporary files should now clean up after
themselves; see the cleanup-dump-file directives in other tests.
                                                                                
The scan-dump checks for tests vect-ifcvt-[2345679].c fail on
powerpc64-linux for both -m32 and -m64; do they need additional
options?
Comment 6 GCC Commits 2005-04-14 18:02:46 UTC
Subject: Bug 21010

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	janis@gcc.gnu.org	2005-04-14 18:02:37

Modified files:
	gcc/testsuite/gcc.dg/vect: vect-ifcvt-1.c vect-ifcvt-2.c 
	                           vect-ifcvt-3.c vect-ifcvt-4.c 
	                           vect-ifcvt-5.c vect-ifcvt-6.c 
	                           vect-ifcvt-7.c vect-ifcvt-9.c 
	gcc/testsuite  : ChangeLog 

Log message:
	PR testsuite/21010
	* gcc.dg/vect/vect-ifcvt-1.c: Remove dg-do, add cleanup.
	* gcc.dg/vect/vect-ifcvt-2.c: Ditto.
	* gcc.dg/vect/vect-ifcvt-3.c: Ditto.
	* gcc.dg/vect/vect-ifcvt-4.c: Ditto.
	* gcc.dg/vect/vect-ifcvt-5.c: Ditto.
	* gcc.dg/vect/vect-ifcvt-6.c: Ditto.
	* gcc.dg/vect/vect-ifcvt-7.c: Ditto.
	* gcc.dg/vect/vect-ifcvt-9.c: Ditto.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/vect/vect-ifcvt-1.c.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/vect/vect-ifcvt-2.c.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/vect/vect-ifcvt-3.c.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/vect/vect-ifcvt-4.c.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/vect/vect-ifcvt-5.c.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/vect/vect-ifcvt-6.c.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/vect/vect-ifcvt-7.c.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/vect/vect-ifcvt-9.c.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5349&r2=1.5350

Comment 7 Janis Johnson 2005-04-14 18:22:55 UTC
Fixed with the patch.  Today the tests pass on powerpc64-linux.