Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 20353
Product:  
Component:  
Status: RESOLVED
Resolution: FIXED
Assigned To: Joseph S. Myers <jsm28@gcc.gnu.org>
Host:
Reported against  
Priority:  
Severity:  
Target Milestone:  
 
 
Target:
Reporter: jbrandmeyer@earthlink.net
Add CC:
CC:
Remove selected CCs
Build:
URL:
Summary:
Keywords:
Known to work:
Known to fail:

Attachment Description Type Created Size Actions
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 20353 depends on: Show dependency tree
Show dependency graph
Bug 20353 blocks:

Additional Comments:






View Bug Activity   |   Format For Printing   |   Clone This Bug

Description:   Last confirmed: 2006-02-10 20:14 Opened: 2005-03-06 23:48 
When optimizing, GCC converts calls to cos() and sin() (and probably others,
these were the ones I saw) into calls to cosf() and sinf() when cos() and sin()
are called with a "float" argument.  The problem with this is that neither
libgcc nor uClibc provide cosf and sinf!  The bug can be worked around by
passing -fno-builtin-cos and -fno-builtin-sin.

The trivial code:
extern double cos(double);
float do_cos(float f)
{ return cos(f); }

Produces this assembly code output:
	.file	"test.c"
	.text
	.align	2
	.global	do_cos
	.type	do_cos, %function
do_cos:
	@ args = 0, pretend = 0, frame = 0
	@ frame_needed = 0, uses_anonymous_args = 0
	@ link register save eliminated.
	@ lr needed for prologue
	b	cosf
	.size	do_cos, .-do_cos
	.ident	"GCC: (GNU) 3.4.2"

When run as "arm-linux-gcc -S -O2 test.c"

Output of "arm-linux-gcc -v:"
Reading specs from
/home/jonathan/workspace/gumstix/gumstix-buildroot/build_arm_nofpu/staging_dir/bin-ccache/../lib/gcc/arm-linux-uclibc/3.4.2/specs
Configured with:
/home/jonathan/workspace/gumstix/gumstix-buildroot/toolchain_build_arm_nofpu/gcc-3.4.2/configure
--prefix=/home/jonathan/workspace/gumstix/gumstix-buildroot/build_arm_nofpu/staging_dir
--build=i386-pc-linux-gnu --host=i386-pc-linux-gnu --target=arm-linux-uclibc
--enable-languages=c,c++ --enable-shared --disable-__cxa_atexit
--enable-target-optspace --with-gnu-ld --disable-nls --with-float=soft
--enable-sjlj-exceptions
Thread model: posix
gcc version 3.4.2

------- Comment #1 From Andrew Pinski 2005-03-06 23:54 ------- 
Note Linux defaults to being glibc which implies that it has C99 math
functions, really uclibc really 
should have a different configure file if it does not have C99 functions.  Well
technicially it should 
provide them anyways as they are required by the C99 standard.

------- Comment #2 From jbrandmeyer@earthlink.net 2005-03-10 00:59 ------- 
uClibc has added these functions to SVN, and they will be available in the next
release of uClibc.  However, their presence is still a configurable option - the
user can configure uClibc to not include any of the C99 math functions.  What is
the best way to configure GCC in this case?  Is there a relevant configure-time
option?  Simply specifying -std=c++98 or -std=c89 is not enough to prevent this
behavior.

------- Comment #3 From Andrew Pinski 2005-03-10 01:08 ------- 
(In reply to comment #2)
> uClibc has added these functions to SVN, and they will be available in the next
> release of uClibc.  However, their presence is still a configurable option - the
> user can configure uClibc to not include any of the C99 math functions.  What is
> the best way to configure GCC in this case?  Is there a relevant configure-time
> option?  Simply specifying -std=c++98 or -std=c89 is not enough to prevent this
> behavior.

None of the above, this is not a runtime configurable thing, as the libc have will it or not at configure 
time.

------- Comment #4 From Andrew Pinski 2005-07-15 21:26 ------- 
uclibc needs its own target headers and triplet.

------- Comment #5 From Joseph S. Myers 2006-02-10 20:14 ------- 
Fixed by my patch <http://gcc.gnu.org/ml/gcc-patches/2006-02/msg00843.html>,
pending review.

------- Comment #6 From Joseph S. Myers 2006-02-16 23:29 ------- 
Subject: Bug 20353

Author: jsm28
Date: Thu Feb 16 23:29:10 2006
New Revision: 111160

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=111160
Log:
gcc:
        PR target/20353
        PR target/24578
        PR target/24837
        * config/linux.opt: New file.
        * config/linux.h (CHOOSE_DYNAMIC_LINKER, UCLIBC_DYNAMIC_LINKER,
        LINUX_DYNAMIC_LINKER): Define.
        (TARGET_C99_FUNCTIONS): Define depending on TARGET_GLIBC.
        * config.gcc (*-*-linux*): Define extra_options.
        (*-*-*uclibc*): Define UCLIBC_DEFAULT.
        (arm*-*-linux-gnueabi): Change to arm*-*-linux-*eabi.
        * config/arm/linux-eabi.h (LINUX_TARGET_INTERPRETER): Change to
        GLIBC_DYNAMIC_LINKER.
        * config/arm/linux-elf.h (LINUX_TARGET_INTERPRETER): Likewise.
        (LINUX_TARGET_LINK_SPEC): Use LINUX_DYNAMIC_LINKER.
        * config/mips/linux.h (GLIBC_DYNAMIC_LINKER): Define.
        (LINK_SPEC): Use LINUX_DYNAMIC_LINKER.
        * doc/invoke.texi (GNU/Linux Options): New section.

gcc/testsuite:
        * gcc.dg/builtins-config.h (HAVE_C99_RUNTIME): Don't define if
        __UCLIBC__ is defined.

libstdc++-v3:
        PR libstdc++/14939
        * config/os/uclibc/ctype_base.h, config/os/uclibc/ctype_inline.h,
        config/os/uclibc/ctype_noninline.h, config/os/uclibc/os_defines.h:
        New.
        * acinclude.m4 (GLIBCXX_CONFIGURE): Test whether using uClibc.
        * configure.host: Use os/uclibc for uClibc.
        * crossconfig.m4 (*-linux*): Use link tests.  Don't hardcode
        presence of math functions.
        * configure: Regenerate.

Added:
    trunk/gcc/config/linux.opt
    trunk/libstdc++-v3/config/os/uclibc/
    trunk/libstdc++-v3/config/os/uclibc/ctype_base.h
    trunk/libstdc++-v3/config/os/uclibc/ctype_inline.h
    trunk/libstdc++-v3/config/os/uclibc/ctype_noninline.h
    trunk/libstdc++-v3/config/os/uclibc/os_defines.h
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config.gcc
    trunk/gcc/config/arm/linux-eabi.h
    trunk/gcc/config/arm/linux-elf.h
    trunk/gcc/config/linux.h
    trunk/gcc/config/mips/linux.h
    trunk/gcc/doc/invoke.texi
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/builtins-config.h
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/acinclude.m4
    trunk/libstdc++-v3/configure
    trunk/libstdc++-v3/configure.host
    trunk/libstdc++-v3/crossconfig.m4

------- Comment #7 From Joseph S. Myers 2006-02-16 23:38 ------- 
Subject: Bug 20353

Author: jsm28
Date: Thu Feb 16 23:38:44 2006
New Revision: 111161

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=111161
Log:
        PR libstdc++/14939
        PR target/20353
        PR target/24578
        PR target/24837
        * gcc/config/linux.opt: New file.
        * gcc/config/linux.h (CHOOSE_DYNAMIC_LINKER,
        UCLIBC_DYNAMIC_LINKER, LINUX_DYNAMIC_LINKER): Define.
        (TARGET_C99_FUNCTIONS): Define depending on TARGET_GLIBC.
        * gcc/config.gcc (*-*-linux*): Define extra_options.
        (*-*-*uclibc*): Define UCLIBC_DEFAULT.
        (arm*-*-linux-gnueabi): Change to arm*-*-linux-*eabi.
        * gcc/config/arm/linux-eabi.h (LINUX_TARGET_INTERPRETER): Change
        to GLIBC_DYNAMIC_LINKER.
        * gcc/config/arm/linux-elf.h (LINUX_TARGET_INTERPRETER): Likewise.
        (LINUX_TARGET_LINK_SPEC): Use LINUX_DYNAMIC_LINKER.
        * gcc/config/mips/linux.h (GLIBC_DYNAMIC_LINKER): Define.
        (LINK_SPEC): Use LINUX_DYNAMIC_LINKER.
        * gcc/doc/invoke.texi (GNU/Linux Options): New section.
        * gcc/testsuite/gcc.dg/builtins-config.h (HAVE_C99_RUNTIME): Don't
        define if __UCLIBC__ is defined.
        * libstdc++-v3/config/os/uclibc/ctype_base.h,
        libstdc++-v3/config/os/uclibc/ctype_inline.h,
        libstdc++-v3/config/os/uclibc/ctype_noninline.h,
        libstdc++-v3/config/os/uclibc/os_defines.h: New.
        * libstdc++-v3/acinclude.m4 (GLIBCXX_CONFIGURE): Test whether
        using uClibc.
        * libstdc++-v3/configure.host: Use os/uclibc for uClibc.
        * libstdc++-v3/crossconfig.m4 (*-linux*): Use link tests.  Don't
        hardcode presence of math functions.
        * libstdc++-v3/configure: Regenerate.

Added:
    branches/csl/sourcerygxx-4_1/gcc/config/linux.opt
    branches/csl/sourcerygxx-4_1/libstdc++-v3/config/os/uclibc/
    branches/csl/sourcerygxx-4_1/libstdc++-v3/config/os/uclibc/ctype_base.h
    branches/csl/sourcerygxx-4_1/libstdc++-v3/config/os/uclibc/ctype_inline.h
   
branches/csl/sourcerygxx-4_1/libstdc++-v3/config/os/uclibc/ctype_noninline.h
    branches/csl/sourcerygxx-4_1/libstdc++-v3/config/os/uclibc/os_defines.h
Modified:
    branches/csl/sourcerygxx-4_1/ChangeLog.csl
    branches/csl/sourcerygxx-4_1/gcc/config.gcc
    branches/csl/sourcerygxx-4_1/gcc/config/arm/linux-eabi.h
    branches/csl/sourcerygxx-4_1/gcc/config/arm/linux-elf.h
    branches/csl/sourcerygxx-4_1/gcc/config/linux.h
    branches/csl/sourcerygxx-4_1/gcc/config/mips/linux.h
    branches/csl/sourcerygxx-4_1/gcc/doc/invoke.texi
    branches/csl/sourcerygxx-4_1/gcc/testsuite/gcc.dg/builtins-config.h
    branches/csl/sourcerygxx-4_1/libstdc++-v3/acinclude.m4
    branches/csl/sourcerygxx-4_1/libstdc++-v3/configure
    branches/csl/sourcerygxx-4_1/libstdc++-v3/configure.host
    branches/csl/sourcerygxx-4_1/libstdc++-v3/crossconfig.m4

------- Comment #8 From Joseph S. Myers 2006-02-16 23:40 ------- 
Fixed for 4.2.

------- Comment #9 From Andrew Pinski 2007-01-03 23:00 ------- 
Subject: Bug 20353

Author: pinskia
Date: Wed Jan  3 23:00:40 2007
New Revision: 120404

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=120404
Log:
2007-01-03  Andrew Pinski  <andrew_pinski@playstation.sony.com>

        PR middle-end/20353
        * gimplify.c (gimplify_modify_expr_complex_part): Move below
        tree_to_gimple_tuple.  Call tree_to_gimple_tuple when we need
        the value.

2007-01-03  Andrew Pinski  <andrew_pinski@playstation.sony.com>

        PR middle-end/30353
        * gcc.c-torture/compile/complex-4.c: New test.



Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/complex-4.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gimplify.c
    trunk/gcc/testsuite/ChangeLog
Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug