Bug 25884 - [4.2 Regression] libgomp should not require perl to compile
Summary: [4.2 Regression] libgomp should not require perl to compile
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: libgomp (show other bugs)
Version: 4.2.0
: P3 normal
Target Milestone: 4.2.0
Assignee: Richard Henderson
URL:
Keywords: build
Depends on:
Blocks: 25259 25925
  Show dependency tree / graph
 
Reported: 2006-01-20 18:11 UTC by Andrew Pinski
Modified: 2006-01-25 19:18 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2006-01-24 16:59:46

Attachments
prototype patch (3.47 KB, patch)
2006-01-20 19:56 UTC, Paolo Bonzini 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Pinski 2006-01-20 18:11:01 UTC 
Like all other target libraries, libgomp should not require perl to compile.

This is either a documention failure as the docs say perl is not required or this is a bug in libgomp for requiring perl.
Comment 1 Paolo Bonzini 2006-01-20 19:56:34 UTC 
Created attachment 10692 [details]
prototype patch

This is a prototype patch to fix the bug using autoconf to compute the necessary sizes/alignments

Note that I'm *not* going to test and submit this patch any further.
Comment 2 Andrew Pinski 2006-01-24 01:03:16 UTC 
In:
http://gcc.gnu.org/install/prerequisites.html
perl version 5.6.1 (or later)
Necessary when regenerating Makefile dependencies in libiberty. Necessary when regenerating libiberty/functions.texi. Necessary when generating manpages from Texinfo manuals. Necessary when targetting Darwin, building libstdc++, and not using --disable-symvers. Used by various scripts to generate some files included in CVS (mainly Unicode-related and rarely changing) from source tables. 


No mention of libgomp here, this is at least a documention bug.
Comment 3 Richard Henderson 2006-01-25 19:18:02 UTC 
Subject: Bug 25884

Author: rth
Date: Wed Jan 25 19:17:57 2006
New Revision: 110220

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110220
Log:
        PR libgomp/25884
        * Makefile.am (omp.h, omp_lib.h, omp_lib.f90, libgomp_f.h): Remove.
        * configure.ac (PERL): Don't set.
        (gstdint.h, omp.h, omp_lib.h, omp_lib.f90, libgomp_f.h): Create here.
        (OMP_LOCK_SIZE, OMP_LOCK_ALIGN, OMP_LOCK_KIND, OMP_NEST_LOCK_SIZE,
        OMP_NEST_LOCK_ALIGN, OMP_NEST_LOCK_KIND): New substitutions.
        * omp.h.in: Wrap the new configure substitutions with @ characters.
        * omp_lib.h.in, omp_lib.f90.in, libgomp_f.h.in: Likewise.
        * aclocal.m4, configure, Makefile.in: Regenerate.
        * mkomp_h.pl: Delete.

Removed:
    trunk/libgomp/mkomp_h.pl
Modified:
    trunk/libgomp/ChangeLog
    trunk/libgomp/Makefile.am
    trunk/libgomp/Makefile.in
    trunk/libgomp/configure
    trunk/libgomp/configure.ac
    trunk/libgomp/libgomp_f.h.in
    trunk/libgomp/omp.h.in
    trunk/libgomp/omp_lib.f90.in
    trunk/libgomp/omp_lib.h.in
    trunk/libgomp/testsuite/Makefile.in
Comment 4 Richard Henderson 2006-01-25 19:18:47 UTC 
Fixed.