Bug 16682 - Frame.setIconImage() not implemented
Summary: Frame.setIconImage() not implemented
Status: RESOLVED FIXED
Alias: None
Product: classpath
Classification: Unclassified
Component: awt (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: pre-0.18
Assignee: djee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-23 01:48 UTC by Bryce McKinlay
Modified: 2005-10-16 01:53 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed:

Attachments
Test case (180 bytes, text/plain)
2004-07-23 01:48 UTC, Bryce McKinlay 		Details
An icon image (797 bytes, image/gif)
2004-07-23 01:49 UTC, Bryce McKinlay 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bryce McKinlay 2004-07-23 01:48:08 UTC 
AWT does not yet support the setIconImage() method to set the toolbar icon for
an application window. Compare the toolbar icon that appears for the attached
test case against the Sun implementation.
Comment 1 Bryce McKinlay 2004-07-23 01:48:54 UTC 
Created attachment 6805 [details]
Test case
Comment 2 Bryce McKinlay 2004-07-23 01:49:27 UTC 
Created attachment 6806 [details]
An icon image
Comment 3 djee 2004-07-30 17:30:50 UTC 
I'll work on this one.  Can someone confirm the bug so I can assign it to
myself?  Thanks.  :)
Comment 4 djee 2004-07-30 18:05:26 UTC 
Fixed in java-gui-branch.  Please verify.
Comment 5 GCC Commits 2004-07-30 20:00:17 UTC 
Subject: Bug 16682

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	java-gui-branch
Changes by:	djee@gcc.gnu.org	2004-07-30 20:00:15

Modified files:
	libjava        : ChangeLog 
	libjava/gnu/java/awt/peer/gtk: GtkFramePeer.java 

Log message:
	2004-07-30  David Jee  <djee@redhat.com>
	
	PR AWT/16682
	* gnu/java/awt/peer/gtk/GtkFramePeer.java
	(setIconImage): Add a FIXME for unhandled cases.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&only_with_tag=java-gui-branch&r1=1.2660.2.307&r2=1.2660.2.308
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/gnu/java/awt/peer/gtk/GtkFramePeer.java.diff?cvsroot=gcc&only_with_tag=java-gui-branch&r1=1.17.2.3&r2=1.17.2.4
Comment 6 GCC Commits 2004-08-05 13:59:19 UTC 
Subject: Bug 16682

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	java-gui-branch
Changes by:	djee@gcc.gnu.org	2004-08-05 13:59:13

Modified files:
	libjava        : ChangeLog 
	libjava/gnu/java/awt/peer/gtk: GtkFramePeer.java GtkImage.java 
	libjava/jni/gtk-peer: gnu_java_awt_peer_gtk_GtkWindowPeer.c 

Log message:
	2004-08-05  David Jee  <djee@redhat.com>
	
	PR AWT/16682
	* gnu/java/awt/peer/gtk/GtkFramePeer.java
	(nativeSetIconImage): Rename to nativeSetIconImageFromDecoder.
	(nativeSetIconImageFromData): New native method declaration.
	(setIconImage): Handle images not produced from GdkPixbufDecoder.
	* gnu/java/awt/peer/gtk/GtkImage.java
	(getPixelCache): New method.
	(getColorModel): New method.
	* jni/gtk-peer/gnu_java_awt_peer_gtk_GtkWindowPeer.c
	(nativeSetIconImage): Rename to nativeSetIconImageFromDecoder.
	(free_pixbuf_data): New helper function.
	(nativeSetIconImageFromData): New function.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&only_with_tag=java-gui-branch&r1=1.2660.2.317&r2=1.2660.2.318
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/gnu/java/awt/peer/gtk/GtkFramePeer.java.diff?cvsroot=gcc&only_with_tag=java-gui-branch&r1=1.17.2.4&r2=1.17.2.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/gnu/java/awt/peer/gtk/GtkImage.java.diff?cvsroot=gcc&only_with_tag=java-gui-branch&r1=1.4.8.2&r2=1.4.8.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkWindowPeer.c.diff?cvsroot=gcc&only_with_tag=java-gui-branch&r1=1.24.2.12&r2=1.24.2.13