Bug 14775 - [3.4 only] LFS tests missing

Attachment

Description

Type

Created

Size

Actions

Create a New Attachment (proposed patch, testcase, etc.)

View All

Bug 14775 depends on:

Show dependency tree
Show dependency graph

Bug 14775 blocks:

Description:

Last confirmed: 2004-03-29 20:00

Opened: 2004-03-29 19:10

(This is just a marker.)

Currently, the libstdc++ testsuite doesn't have any tests for LFS (large file
support.) It would probably be a wise idea to add something, just so system
integrators could use it as part of toolchain testing.

Jakub says:
 glibc has LFS tests, but I don't think too many of them actually play with >
4GB files but it is trivial, just lseek to 4GB+epsilon, write a few bytes, do
the tests, remove the file

So, that's something to think about, although the prospects of putting a 4GB+
file on disk, even for a little bit, will no doubt terrify some people.

-benjamin

------- Comment #2 From Paolo Carlini 2004-03-29 19:33 -------

Hi. This is definitely in my TODO list. I already have the skeleton of a test,
adapted from glibc. And, the nice thing is that most modern filesystems support
sparse files, this means a 4G+eps file is never *actually* written! Good.

I would appreciate help on the following two items, however:
1- When and where running the test? Shall we run it everywhere, XFAILed? Or only
on LFS-enabled machines, possibly just wrapping the test in _GLIBCXX_USE_LFS?? 
Note that 64bit machines may actually be able to access > 4G files even if USE_LFS
is not defined!
2- The shell issue! We must make sure the ulimit are Ok when the test is run. This
is not the case by default on bash and tcsh.

------- Comment #3 From Benjamin Kosnik 2004-03-29 19:50 -------

Subject: Re:  LFS tests missing


>Hi. This is definitely in my TODO list. I already have the skeleton of a test,
>adapted from glibc. And, the nice thing is that most modern filesystems support
>sparse files, this means a 4G+eps file is never *actually* written! Good.

I figured you were on this: I just wanted to make sure it doesn't get lost.

>1- When and where running the test? Shall we run it everywhere, XFAILed? Or only
>on LFS-enabled machines, possibly just wrapping the test in _GLIBCXX_USE_LFS?? 
>Note that 64bit machines may actually be able to access > 4G files even if USE_LFS
>is not defined!

I think we should only run this test if _GLIBCXX_USE_LFS, regardless of
the underlying characteristics of the host os.

Probably something like the __enc_filebuf tests. 

>2- The shell issue! We must make sure the ulimit are Ok when the test is run. This
>is not the case by default on bash and tcsh.

Yeah, I don't know what to do with this bit. Can't you just use something like

__gnu_test::set_memory_limits

?

-benjamin

------- Comment #4 From Paolo Carlini 2004-03-29 20:00 -------

Ok, thanks for your help! I'm assigning the enhancement request to myself...

------- Comment #6 From Benjamin Kosnik 2004-05-13 20:29 -------

Paolo, any chance you can add this to gcc-3_4-branch and close out this bug report?

best,
benjamin

GCC Bugzilla Bug 14775

[3.4 only] LFS tests missing

Last modified: 2004-05-14 10:55:25

Known to work:
Known to fail: